fix(follower): do not cache authentication tokens #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid caching authentication tokens in the client since they can expire. In those cases the client cannot invalidate the expired token, hence it will not have permission to access the resources. Each time the client will acquire a new token based on it's configuration. Remember that this change does not affect the underlying credential helper's cache. Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
|
/hold |
alacuku
force-pushed
the
kcl/disable-client-cache-in-follow-mode
branch
2 times, most recently
from
1025bfc
to
7af0093
Compare
When we create the http client for a given repository the code checks if it is somehow configured. It caches a function called `credentialFunction`. This function knows how to retrieve the credentials for a given repository. For unconfigured repositories, or repositories that fail to get valid credentials using their `credentialFunction,` we cache an `emptyCredential function`. This causes trouble in case of transient errors causing the client to not recover. This commit avoids caching the `emptyCredential function` in such cases or for unconfigured repositories. Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
alacuku
force-pushed
the
kcl/disable-client-cache-in-follow-mode
branch
from
7af0093
to
97c73ef
Compare
|
/unhold @FedeDP ready for review. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 5a2a22bc70296bbbdbc2dab7cfbe6a7d57a02d63
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area cli
What this PR does / why we need it:
Token caching in the client
Avoid caching authentication tokens in the client since they can expire. In those cases the client cannot invalidate the expired token, hence it will not have permission to access the resources.
Each time the client will acquire a new token based on it's configuration. Remember that this change does not affect the underlying credential helper's cache.
CredentialFuncs caching for repositories
When we create the http client for a given repository the code checks if it is somehow configured. It caches a function called
credentialFunction. This function knows how to retrieve the credentials for a given repository. For unconfigured repositories, or repositories that fail to get valid credentials using theircredentialFunction,we cache anemptyCredential function. This causes trouble in case of transient errors causing the client to not recover. This commit avoids caching theemptyCredential functionin such cases or for unconfigured repositories.Remember that the caching of
credentialFunctionsprevents falcoctl in follow mode to pick up new configurations for repositories that at startup time had a working configuration.Which issue(s) this PR fixes:
Fixes #325
Special notes for your reviewer: