Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(artifact/manifest): add manifest command #351

Merged
merged 2 commits into from Nov 16, 2023

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Nov 16, 2023

It allows to fetch the manifest for a given artifact based on it's platform.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it:
Add a new command for artifacts: falcoctl artifact manifest which fetches the manifest layer for a given artifact.

❯ falcoctl artifact manifest k8saudit --platform linux/arm64 | jq
{
  "schemaVersion": 2,
  "mediaType": "application/vnd.oci.image.manifest.v1+json",
  "config": {
    "mediaType": "application/vnd.cncf.falco.plugin.config.v1+json",
    "digest": "sha256:75ff683c3b711f2425e41faeb11830eae49b3ad9e76087cf4c49f2dad0c5e71f",
    "size": 102
  },
  "layers": [
    {
      "mediaType": "application/vnd.cncf.falco.plugin.layer.v1+tar.gz",
      "digest": "sha256:8987a995fa09518aebc488ba549448166d605596c2d6478c10415a9d9f5f05dd",
      "size": 3837491,
      "annotations": {
        "org.opencontainers.image.title": "k8saudit-0.6.1-linux-aarch64.tar.gz"
      }
    }
  ],
  "annotations": {
    "org.opencontainers.image.created": "2023-09-21T07:47:28Z",
    "org.opencontainers.image.source": "https://github.com/falcosecurity/plugins.git"
  }
}

Which issue(s) this PR fixes:
#333

Fixes #
#333
Special notes for your reviewer:

It allows to fetch the manifest for a given artifact based on it's platform.

Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
FedeDP
FedeDP previously approved these changes Nov 16, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Nov 16, 2023

LGTM label has been added.

Git tree hash: 945f3dc9e58b5ff717b7f775c3176f7755e1353b

Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Nov 16, 2023
@poiana
Copy link
Contributor

poiana commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Nov 16, 2023

LGTM label has been added.

Git tree hash: 14142df01d2882d8c154571fa5486ba08e147792

@poiana poiana merged commit 1ad11db into falcosecurity:main Nov 16, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants