Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(pkg/driver): added tests for driver distros implementations. #355

Merged
merged 1 commit into from Nov 24, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Nov 23, 2023

What type of PR is this?

/kind bug

/kind feature

Any specific area of the project related to this PR?

/area library
/area tests

What this PR does / why we need it:

Moreover, fixed some discovered issues.

Which issue(s) this PR fixes:

Refs #327

Fixes #

Special notes for your reviewer:

@FedeDP
Copy link
Contributor Author

FedeDP commented Nov 23, 2023

/cc @alacuku

Moreover, fixed some discovered issues.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Copy link
Member

@alacuku alacuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@poiana
Copy link
Contributor

poiana commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 42c069e into main Nov 24, 2023
14 checks passed
@poiana poiana deleted the new/test_driver_distros branch November 24, 2023 11:26
@FedeDP
Copy link
Contributor Author

FedeDP commented Nov 28, 2023

/milestone v0.7.0

@poiana poiana added this to the v0.7.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants