chore(pkg/driver): do not fail if /sys/kernel/debug fails to be mounted. #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedeDP
force-pushed
the
chore/mount_kernel_debug_no_fail
branch
from
2efc9e2
to
8683bc8
Compare
alacuku
reviewed
Nov 30, 2023
Also check if `/sys/kernel/debug/tracing` exists. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP
force-pushed
the
chore/mount_kernel_debug_no_fail
branch
from
c746e6d
to
d5dbba7
Compare
alacuku
approved these changes
Nov 30, 2023
leogr
approved these changes
Nov 30, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone v0.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area library
What this PR does / why we need it:
Mount
/sys/kernel/debugcan fail in lots of circumstances; for example if it is already mounted.Since we don't always need it (indeed we only need it for x86_64 kernel releases between 4.14 and 4.17), just don't fail.
This is the same behavior that the old falco-driver-loader had: https://github.com/falcosecurity/falco/blob/master/scripts/falco-driver-loader#L628.
Also, bumped driverkit library to v0.16.0 (latest release).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: