Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cmd): fixed up some strings. #407

Merged
merged 1 commit into from
Jan 25, 2024
Merged

chore(cmd): fixed up some strings. #407

merged 1 commit into from
Jan 25, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 25, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area cli

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@poiana
Copy link
Contributor

poiana commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 4ec8660 into main Jan 25, 2024
13 of 14 checks passed
@poiana poiana deleted the chore/fixup_some_strings branch January 25, 2024 08:32
@FedeDP
Copy link
Contributor Author

FedeDP commented Feb 8, 2024

/milestone v0.7.2

@poiana poiana added this to the v0.7.2 milestone Feb 8, 2024
@FedeDP FedeDP mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants