pkg/driver/flatcar: Update the script #425
Conversation
|
/milestone v0.8.0
I'd say that's ok since this is what was already done by the old |
Yeah, tested it on image with glibc 2.38 and it worked - |
It was taken straight from the old driver loader bash script, but now it's a separate script, so some constructs like `local` make no sense there. A result was that no kernel tools were patched, thus they could fail to run if they were built against a newer glibc than the one provided by the falco-driver-loader image. Also print both standard output and standard error on failure, so we may have some idea about what's going on here. Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
krnowak
force-pushed
the
krnowak/flatcar-fixes
branch
from
a4d0618
to
8ed6031
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, krnowak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: f2e9585ebc3ebbc547343fb07f24f0512bf5b95e
|
|
/milestone v0.7.2 |
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area library
What this PR does / why we need it:
Fixes building kernel module on Flatcar. The bash script that was relocating the kernel tools had some issues.
It was taken straight from the old driver loader bash script, but now it's a separate script, so some constructs like
localmake no sense there. A result was that no kernel tools were patched, thus they could fail to run if they were built against a newer glibc than the one provided by the falco-driver-loader image.Also print the output of the script unconditionally, so we may have some idea about what's going on here.
Special notes for your reviewer:
I hope that hardcoding
/hostas host root is fine - I can't see it being provided for customization purposes. Using HOST_ROOT env var wouldn't work if it was provided through--host-rootflag.