Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra '$' character. #458

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

thejefflarson
Copy link
Contributor

Fixes #457

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it:

This removes an extra '$' that was preventing the build process from reading the build log on failure.

Which issue(s) this PR fixes:

Fixes #457

Special notes for your reviewer:

Hope this helps!

Fixes falcosecurity#457

Signed-off-by: Jeff Larson <thejefflarson@gmail.com>
@poiana
Copy link
Contributor

poiana commented Feb 28, 2024

Welcome @thejefflarson! It looks like this is your first PR to falcosecurity/falcoctl 🎉

@poiana poiana added the size/XS label Feb 28, 2024
@thejefflarson thejefflarson mentioned this pull request Feb 28, 2024
@cpanato
Copy link
Member

cpanato commented Feb 28, 2024

/ok-to-test

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks

@poiana
Copy link
Contributor

poiana commented Feb 28, 2024

LGTM label has been added.

Git tree hash: 3f97f48d0baff45a32e58212e7ed1f4f44d9c721

@poiana
Copy link
Contributor

poiana commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, thejefflarson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 85f1edd into falcosecurity:main Feb 28, 2024
16 checks passed
@thejefflarson
Copy link
Contributor Author

Thank you! I'm honored :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible typo?
3 participants