Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd/push): parse requirements and deps from rulesfile #467

Merged

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Mar 8, 2024

When the user does not provide requirements and dependencies when pushing a rulefile artifact, it will try to parse the rulefile and automatically set them in the config layer. It only supports files in .yaml format.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it:
feat(cmd/push): parse requirements and deps from rulesfile

When the user does not provide requirements and dependencies
when pushing a rulefile artifact, it will try to parse the
rulefile and automatically set them in the config layer.
It only supports files in .yaml format.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

When the user does not provide requirements and dependencies
when pushing a rulefile artifact, it will try to parse the
rulefile and automatically set them in the config layer.
It only supports files in .yaml format.

Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Mar 13, 2024

LGTM label has been added.

Git tree hash: 3a97df151ba971879533903f985d152bf6a5b070

@FedeDP
Copy link
Contributor

FedeDP commented Mar 13, 2024

/milestone v0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants