Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cmd,pkg,internal): switch to use oras-go credentials package since oras-go-credentials is deprecated #496

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Mar 28, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area library

What this PR does / why we need it:

See oras-project/oras-credentials-go#80.
Since oras-go-credentials v0.4.0, it is advised to use oras-go credentials package instead of oras-go-credentials (that is now deprecated).

Which issue(s) this PR fixes:

Fixes #419

Special notes for your reviewer:

…since `oras-go-credentials` is deprecated.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Mar 28, 2024

/cc @leogr

@poiana poiana requested a review from leogr March 28, 2024 08:24
@poiana
Copy link
Contributor

poiana commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 7a2d69e into main Mar 28, 2024
17 checks passed
@poiana poiana deleted the chore/use_oras-go_credentials branch March 28, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants