Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slack Alerts] Change Header to only include Rule Name #15

Closed
natalysheinin opened this issue May 8, 2019 · 3 comments
Closed

[Slack Alerts] Change Header to only include Rule Name #15

natalysheinin opened this issue May 8, 2019 · 3 comments

Comments

@natalysheinin
Copy link

natalysheinin commented May 8, 2019 •
edited

Currently, if your falco rule output is fairly long, each slack alert by falcosidekick will spit out a really ugly json blob (even though that information is already captured in the slack event right below).

I think it may make sense to change it to be just the rule name or configurable via environment variables.

image
@natalysheinin natalysheinin changed the title [Slack Alerts] Only include Rule [Slack Alerts] Change Header to only include Rule Name May 8, 2019
@Issif
Copy link
Member

Issif commented May 9, 2019

Hi,

Do you mean something like that?

image

I can add an variable SLACK_DETAILED_FIELDS=(true|false) to handle that.

@Issif Issif mentioned this issue May 9, 2019
Closed
Issif added a commit that referenced this issue May 9, 2019
@Issif
Merge pull request #18 from Issif/v1.0.6
aff03bd 
## 1.0.6 - 2019-05-09
#### New
- Add `SLACK_HIDE_FIELDS` env var, to enable concise output in Slack (fields are not displayed) ([issue #15](https://github.com/Issif/falcosidekick/issues/15))
#### Enhancement
- Remove `/checkPayload` endpoint, not usefull anymore
- Change of how enabled/disabled outputs are printed in log (more concise view)
- Falco's payload is printed in log if `DEBUG=true`
@Issif
Copy link
Member

Issif commented May 9, 2019

merged with #18

@Issif
Copy link
Member

Issif commented May 9, 2019

fixed by #19

@Issif Issif closed this as completed May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Issif @natalysheinin