Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HTTP server handler #116

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

KeisukeYamashita
Copy link
Contributor

Signed-off-by: KeisukeYamashita 19yamashita15@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

/area helm

What this PR does / why we need it:

I refactored some HTTP handler code:

  • Use the http.StatusBadRequest instead of magic number 400
  • Stop sending HTTP request to / for /test endpoint

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
@poiana
Copy link

poiana commented Nov 20, 2020

@KeisukeYamashita: The label(s) area/build cannot be applied, because the repository doesn't have them

In response to this:

Signed-off-by: KeisukeYamashita 19yamashita15@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

/area helm

What this PR does / why we need it:

I refactored some HTTP handler code:

  • Use the http.StatusBadRequest instead of magic number 400
  • Stop sending HTTP request to / for /test endpoint

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart, I discover something new, that makes me happy. Thanks.

@poiana
Copy link

poiana commented Nov 20, 2020

LGTM label has been added.

Git tree hash: a6ec1b90fa1945ba7266d02131b22a74b591c938

@poiana
Copy link

poiana commented Nov 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 2437061 into falcosecurity:master Nov 20, 2020
@KeisukeYamashita KeisukeYamashita deleted the refactor-handler branch November 20, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants