Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .dockerignore for small Docker images #126

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

KeisukeYamashita
Copy link
Contributor

@KeisukeYamashita KeisukeYamashita commented Nov 23, 2020

Signed-off-by: KeisukeYamashita 19yamashita15@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

/area helm

What this PR does / why we need it:

Optimization.
We don't need .git/(3.4MB) and img/ (1.0MB) in the docker image. Smaller Docker images will use fewer resources and it makes the image safer.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Adding to much Docker ignore files worsen the build time and I think other files(e.g. README.md(32KB)) does not worth ignoring it.

Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
@poiana
Copy link

poiana commented Nov 23, 2020

@KeisukeYamashita: The label(s) area/build cannot be applied, because the repository doesn't have them

In response to this:

Signed-off-by: KeisukeYamashita 19yamashita15@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

/area helm

What this PR does / why we need it:

Optimization.
We don't need .git/(3.4MB) and img/ (1.0MB) in the docker image. Smaller Docker images will use fewer resources and safer.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Adding to much Docker ignore files worsen the build time and I think other files(e.g. README.md(32KB)) does not worth ignoring it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link

poiana commented Nov 23, 2020

@cpanato: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart. I love it.

@poiana
Copy link

poiana commented Nov 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the lgtm label Nov 23, 2020
@poiana
Copy link

poiana commented Nov 23, 2020

LGTM label has been added.

Git tree hash: 5de5d93ad6123d122a549d4f748f63cb5907797c

@poiana poiana merged commit b8e117b into falcosecurity:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants