New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure: add missing statds/dogstastd metrics #146
Conversation
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area outputs |
|
||
c.Stats.AzureEventHub.Add(Total, 1) | ||
// setEventHubErrorMetrics set the error stats | ||
func (c *Client) setEventHubErrorMetrics() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving the MR, but I'm surprised you change the pattern for error stats for only this ouput
LGTM label has been added. Git tree hash: bec7555877b5ce5429e70404247788dff0f75a6d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
azure: add missing statds/dogstastd metrics
Which issue(s) this PR fixes:
Fixes partially #144
Special notes for your reviewer:
/assign @Issif