Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output WebUI #180

Merged
merged 4 commits into from
Feb 7, 2021
Merged

Output WebUI #180

merged 4 commits into from
Feb 7, 2021

Conversation

Issif
Copy link
Member

@Issif Issif commented Feb 5, 2021

Signed-off-by: Issif issif_github@gadz.org<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, please read our contributor guidelines in the CONTRIBUTING.md file and learn how to compile Falco from source here.
  2. Please label this pull request according to what type of issue you are addressing.
  3. If the PR is unfinished while opening it specify a wip in the title before the actual title, for example, "wip: my awesome feature"
    -->

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

This PR prepares the incoming WebUI for falcosidekick as new Output.

image

I need it for using new exported types.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: Issif <issif_github@gadz.org>
Signed-off-by: Issif <issif_github@gadz.org>
Signed-off-by: Issif <issif_github@gadz.org>
@Issif Issif added this to the 2.21.0 milestone Feb 5, 2021
@Issif Issif added this to In progress in 2.x via automation Feb 5, 2021
@poiana poiana added the size/L label Feb 5, 2021
@danpop-chainguard
Copy link

/lgtm

Copy link
Contributor

@KeisukeYamashita KeisukeYamashita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, I left comment regarding the webui.address field. PTAL when you have a change 😉

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
config_example.yaml Outdated Show resolved Hide resolved
handlers.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
types/types.go Outdated Show resolved Hide resolved
config_example.yaml Show resolved Hide resolved
Copy link
Contributor

@KeisukeYamashita KeisukeYamashita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either Web Address or URL would be fine, otherwise it's LGTM!

@Issif
Copy link
Member Author

Issif commented Feb 6, 2021

Either Web Address or URL would be fine, otherwise it's LGTM!

@KeisukeYamashita I'm ok with your proposal, just FYI, I tried to use same pattern than outputs use in their documentation. For example, Slack calls it Webhook URL, Elasticsearck it's Host:Port, too. This is why there's no global coherence in falcosidekick config, but in my mind it was with outputs for helping who already know them.

For WebUI, as it's our own product, we can do whatever we want. I'll apply your suggestions. Thanks 👍

Signed-off-by: Issif <issif_github@gadz.org>
@Issif
Copy link
Member Author

Issif commented Feb 6, 2021

@KeisukeYamashita I did it 👍

Copy link
Contributor

@KeisukeYamashita KeisukeYamashita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating, LGTM 💯

@poiana poiana added the lgtm label Feb 7, 2021
@poiana
Copy link

poiana commented Feb 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danpopSD, KeisukeYamashita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Feb 7, 2021

LGTM label has been added.

Git tree hash: d15d553c1b5a332755e0db702ff769a9f2668409

@poiana poiana added the approved label Feb 7, 2021
@poiana poiana merged commit 20c6b46 into master Feb 7, 2021
2.x automation moved this from In progress to Done Feb 7, 2021
@poiana poiana deleted the falcosidekick-ui-v2 branch February 7, 2021 02:23
@cpanato
Copy link
Member

cpanato commented Feb 7, 2021

late for the party
/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2.x
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants