Prevent misleading error message when setting CUSTOMFIELDS env var #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents this error from being printed out, which doesn't actually prevent CUSTOMFIELDS from being set properly ``` 2021/03/03 15:36:59 [ERROR] : Error unmarshalling config : 1 error(s) decoding: * 'Customfields' expected a map, got 'string' ``` Signed-off-by: Joseph Zemek <joseph@robinhood.com>
|
Welcome @zemek! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 93f241ad832c53d3575f9dc5f27b7249b8f98ae0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area config
What this PR does / why we need it:
This prevents this error from being printed out, which doesn't actually prevent CUSTOMFIELDS from being set properly via an environment variable
This default also isn't actually needed since we already initialize an empty string map in the config struct. This makes the behavior of CUSTOMFIELDS the same as Webhook.CustomHeaders and CloudEvents.Extensions which don't set this default and don't have this issue.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: