Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added GCP Storage output type #202

Merged
merged 8 commits into from
Mar 29, 2021
Merged

Added GCP Storage output type #202

merged 8 commits into from
Mar 29, 2021

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Mar 4, 2021 •
edited

Signed-off-by: Yuvraj evalsocket@gmail.com

What type of PR is this?

kind feature

Any specific area of the project related to this PR?

area outputs

What this PR does / why we need it: Added new output type GCP storage

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana poiana requested review from cpanato and nibalizer March 4, 2021 00:02
@poiana
Copy link

poiana commented Mar 4, 2021

@evalsocket: There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana added the size/L label Mar 4, 2021
@Issif Issif added this to In progress in 2.x via automation Mar 4, 2021
@Issif Issif added this to the 2.22.0 milestone Mar 4, 2021
@yindia yindia marked this pull request as ready for review March 6, 2021 09:00
@yindia yindia changed the title [WIP] Added GCP output type Added GCP output type Mar 6, 2021
@Issif
Copy link
Member

Issif commented Mar 8, 2021

This is a terrific PR, thank you so much

/lgtm

As it's a big one, please @cpanato @KeisukeYamashita, take a look too when you can 🙏

@poiana poiana added the lgtm label Mar 8, 2021
@poiana
Copy link

poiana commented Mar 8, 2021

LGTM label has been added.

Git tree hash: 45ac01fdb582ecb48da21d2db0b0e61351ffed3e

Issif
Issif requested changes Mar 12, 2021
View reviewed changes
outputs/gcp.go Outdated Show resolved Hide resolved
@poiana poiana removed the approved label Mar 12, 2021
@yindia yindia requested a review from Issif March 13, 2021 07:50
yindia and others added 6 commits March 25, 2021 22:36
@yindia
wip: Added GCP output type
616e9bf 
Signed-off-by: Yuvraj <evalsocket@gmail.com>
@yindia
wip: Added gcp handler
93c108f 
Signed-off-by: Yuvraj <evalsocket@gmail.com>
@yindia
wip: tested gcp
65c808f 
Signed-off-by: Yuvraj <evalsocket@gmail.com>
@yindia
wip: cleanup
068a2b2 
Signed-off-by: Yuvraj <evalsocket@gmail.com>
@yindia
resolve conflict
5cd0ca2 
Signed-off-by: yuvraj <evalsocket@gmail.com>
@yindia
wip: typo fix
3e9c7c4 
Signed-off-by: yuvraj <evalsocket@gmail.com>
@yindia
wip: fix merge conflict
e36125e 
Signed-off-by: yuvraj <evalsocket@gmail.com>
Issif
Issif requested changes Mar 25, 2021
View reviewed changes
outputs/client.go Outdated Show resolved Hide resolved
@yindia
revert pagerduty change
a9a75bb 
Signed-off-by: yuvraj <evalsocket@gmail.com>
Issif
Issif reviewed Mar 26, 2021
View reviewed changes
main.go Show resolved Hide resolved
Issif
Issif requested changes Mar 26, 2021
View reviewed changes
outputs/client.go Show resolved Hide resolved
@poiana poiana added the lgtm label Mar 29, 2021
@poiana
Copy link

poiana commented Mar 29, 2021

LGTM label has been added.

Git tree hash: 79ab008babcda0f4ca6cb7bf7b8e51b8e9504198

@poiana
Copy link

poiana commented Mar 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 94fb469 into falcosecurity:master Mar 29, 2021
2.x automation moved this from In progress to Done Mar 29, 2021
@Issif Issif changed the title Added GCP output type Added GCP Storage output type Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Issif Issif Issif approved these changes

@cpanato cpanato Awaiting requested review from cpanato

@nibalizer nibalizer Awaiting requested review from nibalizer

Assignees

@Issif Issif

Labels
approved dco-signoff: yes lgtm needs-kind size/L
Projects
Falcosidekick 2.x
Status: Done
2.x
Done
Milestone
2.22.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yindia @poiana @Issif