Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix statsd/dogstatsd: NewStatsdClient never initiated for Dogstatsd #227

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

Issif
Copy link
Member

@Issif Issif commented Apr 12, 2021

Signed-off-by: Issif issif_github@gadz.org

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

Init of DogstatsD client is broken.

Which issue(s) this PR fixes:

#225

Fixes #

Special notes for your reviewer:

Signed-off-by: Issif <issif_github@gadz.org>
@poiana
Copy link

poiana commented Apr 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fjogeleit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Apr 13, 2021

LGTM label has been added.

Git tree hash: 88879bcea37dd150dc36383eb0af7178ef3c4f57

@poiana poiana merged commit d0fd27b into master Apr 13, 2021
@poiana poiana deleted the dogstatsd branch April 13, 2021 15:12
@Issif Issif added this to In progress in 2.x via automation Apr 15, 2021
@Issif Issif added this to the 2.23.0 milestone Apr 15, 2021
@Issif Issif moved this from In progress to Done in 2.x May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2.x
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants