Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check nil pointer before reference to SSECustomerKeyMD5 #242

Merged
merged 1 commit into from
May 22, 2021
Merged

check nil pointer before reference to SSECustomerKeyMD5 #242

merged 1 commit into from
May 22, 2021

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented May 22, 2021

Signed-off-by: Kaizhe Huang khuang@aurora.tech

What type of PR is this?

Bug fix

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

This PR is to fix issue #234

Which issue(s) this PR fixes:

#234

Fixes #

Special notes for your reviewer:

Signed-off-by: Kaizhe Huang <khuang@aurora.tech>
@Kaizhe
Copy link
Contributor Author

Kaizhe commented May 22, 2021

/kind bug

@poiana poiana added kind/bug Something isn't working and removed needs-kind labels May 22, 2021
@developer-guy
Copy link
Contributor

/lgtm

@poiana
Copy link

poiana commented May 22, 2021

LGTM label has been added.

Git tree hash: 78c67c52173d6489631ebf1dd66c463d53145d72

@poiana
Copy link

poiana commented May 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: developer-guy, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Issif,developer-guy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Issif Issif added this to In progress in 2.x via automation May 22, 2021
@Issif Issif added this to the 2.23.0 milestone May 22, 2021
@poiana poiana merged commit 438feec into falcosecurity:master May 22, 2021
2.x automation moved this from In progress to Done May 22, 2021
@Kaizhe Kaizhe deleted the kh_fix-s3-upload-failure branch June 6, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2.x
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants