Yandex S3 output #261
Merged
Yandex S3 output #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Narek Tatevosyan <nrkk@yandex-team.ru>
Signed-off-by: Narek Tatevosyan nrkk@yandex-team.ru
|
/assign @leodido |
Issif
requested changes
Aug 4, 2021
Signed-off-by: Narek Tatevosyan nrkk@yandex-team.ru Co-authored-by: Thomas Labarussias <issif+github@gadz.org>
Signed-off-by: Narek Tatevosyan nrkk@yandex-team.ru Co-authored-by: Thomas Labarussias <issif+github@gadz.org> Signed-off-by: nar3k <nrkk@yandex-team.ru>
Issif
requested changes
Aug 5, 2021
config.go
Outdated
| @@ -358,6 +366,7 @@ func getConfig() *types.Configuration { | |||
| c.Fission.MinimumPriority = checkPriority(c.Fission.MinimumPriority) | |||
| c.Rabbitmq.MinimumPriority = checkPriority(c.Rabbitmq.MinimumPriority) | |||
| c.Wavefront.MinimumPriority = checkPriority(c.Wavefront.MinimumPriority) | |||
| c.Yandex.S3.MinimumPriority = checkPriority(c.Wavefront.MinimumPriority) | |||
There was a problem hiding this comment.
Suggested change
| c.Yandex.S3.MinimumPriority = checkPriority(c.Wavefront.MinimumPriority) | |
| c.Yandex.S3.MinimumPriority = checkPriority(c.Yandex.S3.MinimumPriority) |
1) S3 endpoint is under s3 config 2) Yandex s3 uses credential library instead of file 3) Small error fixes Signed-off-by: Narek Tatevosyan <nrkk@yandex-team.ru>
poiana
added
dco-signoff: yes
and removed
dco-signoff: no
do-not-merge/contains-merge-commits
labels
|
I hope it should be fine right now Sorry for the spam , im new to github community - this PR gave me a lot of experience |
No problem, I'm here for helping you to contribute. |
Issif
requested changes
Aug 5, 2021
Signed-off-by: Narek Tatevosyan <nrkk@yandex-team.ru> Co-authored-by: Thomas Labarussias <issif+github@gadz.org>
|
LGTM label has been added. Git tree hash: d3a32b5c15bb3c2e1119824c93f41e39b6b601f1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, nar3k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
Which issue(s) this PR fixes:
#258
Fixes #
Special notes for your reviewer: