Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add step to push to aws ecr too #265

Merged
merged 1 commit into from
Aug 13, 2021
Merged

ci: add step to push to aws ecr too #265

merged 1 commit into from
Aug 13, 2021

Conversation

maxgio92
Copy link
Member

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

This PR adds a job to build and publish a container image to AWS public ECR registry.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

We try to make OCI artifacts highly available by hosting them on different public registries like Docker Hub and AWS ECR.

Signed-off-by: maxgio92 <massimiliano.giovagnoli.1992@gmail.com>
@poiana
Copy link

poiana commented Aug 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, maxgio92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maxgio92
Copy link
Member Author

This is a work in progress, as the AWS ECR repositories need to be in place before trying to push images to them.

@Issif Issif added this to In progress in 2.x via automation Aug 12, 2021
@Issif Issif added this to the 2.25.0 milestone Aug 12, 2021
@maxgio92 maxgio92 changed the title wip: ci: add step to push to aws ecr too ci: add step to push to aws ecr too Aug 13, 2021
@poiana poiana merged commit 2fadfdb into falcosecurity:master Aug 13, 2021
2.x automation moved this from In progress to Done Aug 13, 2021
@Issif Issif modified the milestones: 2.25.0, 2.24.0 Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2.x
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants