Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priority label to alertmanager alerts #276

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

mac-chaffee
Copy link
Contributor

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area outputs

What this PR does / why we need it:

Adds the "priority" field from Falco as an alertmanager Label. Helps users route alerts to different notification backends based on priority.

Which issue(s) this PR fixes:

Fixes #275

Special notes for your reviewer:

You were right @Issif , that was easy!

Signed-off-by: Mac Chaffee <me@macchaffee.com>
@poiana
Copy link

poiana commented Oct 8, 2021

Welcome @mac-chaffee! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana added the size/XS label Oct 8, 2021
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana poiana added the lgtm label Oct 8, 2021
@poiana
Copy link

poiana commented Oct 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, mac-chaffee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Oct 8, 2021

LGTM label has been added.

Git tree hash: ef40fd108ab6c4bfaada7e726df25fcfca9141ef

@poiana poiana added the approved label Oct 8, 2021
@poiana poiana merged commit 5ee27aa into falcosecurity:master Oct 8, 2021
@Issif Issif added this to In progress in 2.x via automation Mar 2, 2022
@Issif Issif added this to the 2.25.0 milestone Mar 2, 2022
@Issif Issif moved this from In progress to Done in 2.x Apr 26, 2022
@Issif Issif mentioned this pull request May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2.x
Done
Development

Successfully merging this pull request may close these issues.

Missing "Priority" in alertmanager notifications
3 participants