Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix typo in README: "ecossytem" #299

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

oleg-nenashev
Copy link
Contributor

@oleg-nenashev oleg-nenashev commented Jan 3, 2022

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind documentation

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana
Copy link

poiana commented Jan 3, 2022

@oleg-nenashev: There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link

poiana commented Jan 3, 2022

Welcome @oleg-nenashev! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana added the size/XS label Jan 3, 2022
@cpanato
Copy link
Member

cpanato commented Jan 3, 2022

@oleg-nenashev can you please sign the DCO? :)

cpanato
cpanato previously approved these changes Jan 3, 2022
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@poiana
Copy link

poiana commented Jan 3, 2022

LGTM label has been added.

Git tree hash: 805535c6a17b2b12183319790ff133f5e53ae4d3

@poiana poiana added the approved label Jan 3, 2022
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
@oleg-nenashev
Copy link
Contributor Author

Fixed DCO @cpanato

@cpanato
Copy link
Member

cpanato commented Jan 3, 2022

/assign @Issif

@poiana
Copy link

poiana commented Jan 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Issif, oleg-nenashev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit fde58f7 into falcosecurity:master Jan 3, 2022
@Issif Issif added this to In progress in 2.x via automation Mar 2, 2022
@Issif Issif added this to the 2.25.0 milestone Mar 2, 2022
@Issif Issif mentioned this pull request Mar 2, 2022
@Issif Issif moved this from In progress to Done in 2.x Apr 26, 2022
@Issif Issif mentioned this pull request May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2.x
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants