Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all outputs for dealing with tags and source #310

Merged
merged 6 commits into from
May 11, 2022
Merged

Conversation

Issif
Copy link
Member

@Issif Issif commented Mar 9, 2022

Signed-off-by: Issif issif+github@gadz.org

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

Since Falco 0.31, new fields source and tags have been added in json events.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@Issif Issif added this to In progress in 2.x via automation Mar 9, 2022
@Issif Issif added this to the 2.25.0 milestone Mar 9, 2022
@poiana poiana added size/XXL and removed size/L labels Mar 9, 2022
@Issif Issif force-pushed the add-tags branch 3 times, most recently from ff0ab73 to eaffcdb Compare March 9, 2022 17:35
@poiana poiana added size/XL and removed size/XXL labels Mar 9, 2022
@Issif Issif changed the title WIP: update all outputs for dealing with tags and source update all outputs for dealing with tags and source Mar 9, 2022
@Issif Issif force-pushed the add-tags branch 3 times, most recently from 228b885 to 46b5554 Compare March 14, 2022 22:24
@Issif Issif requested a review from cpanato April 26, 2022 14:22
Issif added 5 commits May 11, 2022 11:05
Signed-off-by: Issif <issif+github@gadz.org>
Signed-off-by: Issif <issif+github@gadz.org>
Signed-off-by: Issif <issif+github@gadz.org>
Signed-off-by: Issif <issif+github@gadz.org>
Signed-off-by: Issif <issif+github@gadz.org>
.golangci.yml Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Issif <issif+github@gadz.org>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool
/lgtm

@poiana
Copy link

poiana commented May 11, 2022

LGTM label has been added.

Git tree hash: ac9db018062d1966d9057138b77e9c895800587b

@poiana
Copy link

poiana commented May 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 74b4d86 into master May 11, 2022
2.x automation moved this from In progress to Done May 11, 2022
@poiana poiana deleted the add-tags branch May 11, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2.x
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants