Close GCS writer on return #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @Milkshak3s! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
Signed-off-by: Milkshak3s <justchris.vantine@gmail.com>
Milkshak3s
force-pushed
the
milkshak3s-bugfix-gcs-close-writer
branch
from
79c04c9
to
ad14f31
Compare
Issif
approved these changes
Apr 14, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, Milkshak3s The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 599b8cd5b5d72aa2f03a29aabb01e74010d5d833
|
|
Thank you 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
Fixes a bug in the GCP
UploadGCSfunction in which the bucket writer is not properly closed, preventing the new object from being written to the remote bucket.Which issue(s) this PR fixes:
(one sec)
Fixes #313
Special notes for your reviewer:
Tested locally.
Previously: new object not written post-execution.
After change: new object is written post-execution.