feat(alertmanager-extra-infos): Adding extra labels or annotations the alert #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issif
reviewed
Jul 22, 2022
Issif
requested changes
Jul 22, 2022
Issif
reviewed
Jul 22, 2022
… the alert Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
|
LGTM label has been added. Git tree hash: 245b150ac473fb2594e6da40cb8312b92c8a338b
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, Lowaiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Lowaiz
added a commit
to Lowaiz/charts
that referenced
this pull request
Jul 26, 2022
…Manager extra labels and annotations. In prevision of sidekick version bump. falcosecurity/falcosidekick#347 Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
3 tasks
Lowaiz
added a commit
to Lowaiz/charts
that referenced
this pull request
Jul 26, 2022
feat(alertmanager-extra-fields): Updates values and secrets for AlertManager extra labels and annotations. In prevision of sidekick version bump. falcosecurity/falcosidekick#341 falcosecurity/falcosidekick#347 Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
Lowaiz
added a commit
to Lowaiz/charts
that referenced
this pull request
Jul 29, 2022
feat(alertmanager-extra-fields): Updates values and secrets for AlertManager extra labels and annotations. In prevision of sidekick version bump. falcosecurity/falcosidekick#341 falcosecurity/falcosidekick#347 Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lyonel Martinez lyonel.martinez@numberly.com
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
Now, we can add extra labels and extra annotations to the alerts send to the AlertManager Output.
Each label/annotation can have a name and a value defined by this format:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
We can use the same format to add extra labels with values to the Prometheus' extra-labels configuration and to the Loki one's.