Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to use envvar as custom fields #353

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Conversation

Issif
Copy link
Member

@Issif Issif commented Aug 5, 2022

Signed-off-by: Thomas Labarussias issif_github@gadz.org

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

It allows to use env vars as custom fields

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: Thomas Labarussias <issif_github@gadz.org>
@Issif Issif added this to the 2.27.0 milestone Aug 5, 2022
@Issif Issif added this to In progress in 2.x via automation Aug 5, 2022
@poiana poiana requested review from fjogeleit and leogr August 5, 2022 20:56
@poiana
Copy link

poiana commented Aug 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fjogeleit, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Aug 5, 2022

LGTM label has been added.

Git tree hash: 4d40804bbfd685f954aa37f610f2eb65eeafde68

@poiana poiana merged commit 2976268 into master Aug 5, 2022
2.x automation moved this from In progress to Done Aug 5, 2022
@poiana poiana deleted the custom-fields-envvar branch August 5, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2.x
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants