Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Loki output to reflect the new API (version before of Loki <1 … #356

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

Issif
Copy link
Member

@Issif Issif commented Aug 23, 2022

…are now deprecated)

Signed-off-by: Thomas Labarussias issif_github@gadz.org

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

This PR updates the default endpoint for Loki output and update the payload format to match the current format

⚠️ Loki < v1 are now deprecated

Which issue(s) this PR fixes:

#351

Fixes #

Special notes for your reviewer:

…are now deprecated)

Signed-off-by: Thomas Labarussias <issif_github@gadz.org>
@Issif Issif added this to In progress in 2.x via automation Aug 23, 2022
@poiana poiana requested review from fjogeleit and leogr August 23, 2022 13:43
@Issif Issif added this to the 2.27.0 milestone Aug 23, 2022
@poiana poiana added the size/M label Aug 23, 2022
@poiana
Copy link

poiana commented Aug 24, 2022

LGTM label has been added.

Git tree hash: 3a232d6488bdbc7e374df79324a32acae4a74cc2

@poiana
Copy link

poiana commented Aug 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fjogeleit, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 7aba0b4 into master Aug 24, 2022
2.x automation moved this from In progress to Done Aug 24, 2022
@poiana poiana deleted the loki-format branch August 24, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2.x
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants