Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update wavefronthq/wavefront-sdk-go to v0.12.0 and fix deprecations #432

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 25, 2023

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?

/area outputs

What this PR does / why we need it:

update wavefronthq/wavefront-sdk-go to v0.12.0 and fix deprecations

/assign @Issif
cc @rikatz

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@rikatz
Copy link
Contributor

rikatz commented Mar 25, 2023

I don't have my wavefront access anymore to test it ;(

Will see if I can get some internally

@Issif
Copy link
Member

Issif commented Mar 25, 2023

I don't have my wavefront access anymore to test it ;(

Will see if I can get some internally

Thank you @rikatz, I'm waiting for your feedback before approving that PR.

Thanks again @cpanato

@Issif Issif added this to the 2.28.0 milestone Apr 24, 2023
@Issif
Copy link
Member

Issif commented Apr 24, 2023

@rikatz what's the status on your side?

@poiana poiana added the lgtm label Apr 27, 2023
@poiana
Copy link

poiana commented Apr 27, 2023

LGTM label has been added.

Git tree hash: 7eeb1449abeeb85f3eac80a85c8f4d04b3031bcc

@poiana
Copy link

poiana commented Apr 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 58ec86e into falcosecurity:master Apr 27, 2023
1 check passed
@cpanato cpanato deleted the update-Wavefront branch April 27, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants