Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setting topiccreation for kafka #554

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

Issif
Copy link
Member

@Issif Issif commented Jul 11, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test
/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config
/area outputs

/area tests

What this PR does / why we need it:

Allow to auto create kafka topic

Which issue(s) this PR fixes:

#546

Fixes #

Special notes for your reviewer:

Signed-off-by: Thomas Labarussias <issif_github@gadz.org>
@poiana poiana requested review from fjogeleit and leogr July 11, 2023 14:24
@Issif Issif added this to the 2.28.0 milestone Jul 11, 2023
@poiana poiana added the size/M label Jul 11, 2023
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@poiana
Copy link

poiana commented Jul 11, 2023

LGTM label has been added.

Git tree hash: 00b71acf19c37e4254388e102244ef4cef4dc982

@poiana
Copy link

poiana commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 86fdf22 into master Jul 11, 2023
5 checks passed
@poiana poiana deleted the kafka-autocreate-topic branch July 11, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants