allow to use tls for kafka

[Issif]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

#547

Fixes #

Special notes for your reviewer:

[ibice]

@Issif I was about to PR this same feature! ibice@7a3aa25

In my solution, I included support for a custom CA. I suppose you plan to support it in the future since you added it to types.go. I'd be happy to add it once this gets merged.

One question out of curiosity, what's the reason behind this? I understand there isn't any client certificate involved.

falcosidekick/outputs/kafka.go

Line 34 in a5ca9ec

ClientAuth: tls.RequireAndVerifyClientCert,

[Issif]

@Issif I was about to PR this same feature! ibice@7a3aa25

In my solution, I included support for a custom CA. I suppose you plan to support it in the future since you added it to types.go. I'd be happy to add it once this gets merged.

One question out of curiosity, what's the reason behind this? I understand there isn't any client certificate involved.

falcosidekick/outputs/kafka.go

Line 34 in a5ca9ec

ClientAuth: tls.RequireAndVerifyClientCert,

I removed the field for the custom ca, I think this config should be global for all outputs, like we do with the key/certs for mTLS. This is something we could add in 2.29.0, don't want to block the 2.28.0 for that.

For the RequireAndVerifyClientCert it's useless, I removed it, thanks for the notice.

[ibice]

@Issif ok, we can rely on the system CAs for now.

Configuring the CA file globally makes sense. Tell me if you need help, I'll be happy to contribute.

Thanks for the feature!

[Issif]

Your contribution is welcome, you can already work on the subject, I'll just add the 2.29.0 as milestone.

[cpanato]

/lgtm

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Issif,cpanato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[poiana]

LGTM label has been added.

Git tree hash: 50a4379ecfcdd650787d277471a69f7fc3ba67a4