Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username parameter for slack/mattermost/rocketchat #72

Merged
merged 1 commit into from Aug 4, 2020

Conversation

Issif
Copy link
Member

@Issif Issif commented Aug 3, 2020

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

/area helm

What this PR does / why we need it:

  • Update golang to 1.14
  • Add a new architecture schema in README
  • Add a new parameter for Slack, Mattermost, Rocketchat : username

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

…rmost + new schema in README

Signed-off-by: Thomas <issif_github@gadz.org>
@poiana
Copy link

poiana commented Aug 4, 2020

LGTM label has been added.

Git tree hash: 64c3e82e45f57cf5348d205d9998c9b03a427edc

@poiana
Copy link

poiana commented Aug 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Aug 4, 2020
@poiana poiana merged commit c539c49 into master Aug 4, 2020
@poiana poiana deleted the username-parameter branch August 4, 2020 12:05
@Issif Issif added this to the 2.14.0 milestone Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants