update(test/drivers): handle msgcontrol parameters also in socketcall…

… tests Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
falcosecurity · Oct 12, 2023 · 73ad7c5 · 73ad7c5
1 parent ed5ff00
commit 73ad7c5
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/test/drivers/test_suites/syscall_exit_suite/recvmsg_x.cpp b/test/drivers/test_suites/syscall_exit_suite/recvmsg_x.cpp
@@ -590,7 +590,7 @@ TEST(SyscallExit, recvmsg_ancillary_data)
 		assert_syscall_state(SYSCALL_SUCCESS, "sendmsg (client)", sent_bytes, NOT_EQUAL, -1);;
 
 		int wstatus;
-		waitpid(-1, &wstatus, 0);
+		waitpid(pid, &wstatus, 0);
 
 		syscall(__NR_shutdown, sock);
 		syscall(__NR_close, sock);

diff --git a/test/drivers/test_suites/syscall_exit_suite/socketcall_x.cpp b/test/drivers/test_suites/syscall_exit_suite/socketcall_x.cpp
@@ -2026,13 +2026,16 @@ TEST(SyscallExit, socketcall_recvmsgX_no_snaplen)
 		///  but these could be empty so this is not the correct way to retrieve information we have to
 		///  change it.
 		evt_test->assert_empty_param(4);
-		evt_test->assert_num_params_pushed(4);
+		evt_test->assert_num_params_pushed(5);
 		GTEST_SKIP() << "[RECVMSG_X]: what we receive is correct but we need to reimplement it, see the code" << std::endl;
 	}
 
+	/* Parameter 5: msg_control (type: PT_BYTEBUF) */
+	evt_test->assert_empty_param(5);
+
 	/*=============================== ASSERT PARAMETERS  ===========================*/
 
-	evt_test->assert_num_params_pushed(4);
+	evt_test->assert_num_params_pushed(5);
 }
 
 TEST(SyscallExit, socketcall_recvmsgX_snaplen)
@@ -2128,13 +2131,16 @@ TEST(SyscallExit, socketcall_recvmsgX_snaplen)
 		///  but these could be empty so this is not the correct way to retrieve information we have to
 		///  change it.
 		evt_test->assert_empty_param(4);
-		evt_test->assert_num_params_pushed(4);
+		evt_test->assert_num_params_pushed(5);
 		GTEST_SKIP() << "[RECVMSG_X]: what we receive is correct but we need to reimplement it, see the code" << std::endl;
 	}
 
+	/* Parameter 5: msg_control (type: PT_BYTEBUF) */
+	evt_test->assert_empty_param(5);
+
 	/*=============================== ASSERT PARAMETERS  ===========================*/
 
-	evt_test->assert_num_params_pushed(4);
+	evt_test->assert_num_params_pushed(5);
 }
 #endif
 
@@ -2186,7 +2192,12 @@ TEST(SyscallExit, socketcall_recvmsgX_fail)
 	/* Parameter 4: tuple (type: PT_SOCKTUPLE) */
 	evt_test->assert_empty_param(4);
 
+	/* Parameter 5: msg_control (type: PT_BYTEBUF) */
+	evt_test->assert_empty_param(5);
+
 	/*=============================== ASSERT PARAMETERS  ===========================*/
+
+	evt_test->assert_num_params_pushed(5);
 }
 
 #endif