fix umount2 syscall flags type, add conversion helper function #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please double check driver/API_VERSION file. See versioning. /hold |
Andreagit97
reviewed
Jul 31, 2023
driver/modern_bpf/programs/tail_called/events/syscall_dispatched_events/umount2.bpf.c
Outdated
Show resolved
Hide resolved
|
without new events, the patch will become easier with just 3/4 files |
oheifetz
force-pushed
the
issue_515_umount2
branch
from
338ccd1
to
ac11cb5
Compare
oheifetz
force-pushed
the
issue_515_umount2
branch
6 times, most recently
from
334fd49
to
d71c567
Compare
Andreagit97
reviewed
Aug 14, 2023
driver/modern_bpf/programs/tail_called/events/syscall_dispatched_events/umount2.bpf.c
Outdated
Show resolved
Hide resolved
oheifetz
force-pushed
the
issue_515_umount2
branch
from
d71c567
to
db7ef95
Compare
- change the flags (param 1) from u32 to s32 - add a userspace to scap flag conversion helper routine Reported by: github issue falcosecurity#515 Signed-off-by: Ofer Heifetz <oheifetz@gmail.com>
oheifetz
force-pushed
the
issue_515_umount2
branch
from
db7ef95
to
87a8701
Compare
|
LGTM label has been added. Git tree hash: 255ba258e4e5398a23efe4a5e3a3180e03a9a54e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, incertum, oheifetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
59 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by: github issue #515
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area driver-bpf
/area driver-modern-bpf
/area libscap
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it: fix umount2 syscall flags type and add conversion helper function
Which issue(s) this PR fixes: github issue #515
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: