Scoped target_link_libraries() commands for libsinsp #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @mprzybylski! It looks like this is your first PR to falcosecurity/libs 🎉 |
mprzybylski
force-pushed
the
scoped_target_link_libraries_cmds_for_sinsp
branch
from
b3ca4bf
to
eb9c9b9
Compare
Migrated 'sinsp' CMake target_link_libraies() commands to the scoped PRIVATE / PUBLIC / INTERFACE signature. This is to minimize the potential for symbol conflicts in applications that use the library. Signed-off-by: Michael Przybylski <michael.przybylski@sysdig.com>
mprzybylski
force-pushed
the
scoped_target_link_libraries_cmds_for_sinsp
branch
from
4a480d2
to
b896e2d
Compare
|
LGTM label has been added. Git tree hash: 40e422fa54dfc5a76429d002adf30b9691dd75da
|
|
before merging it, I would like to test it on Falco, I will take a look ASAP thank you! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, jasondellaluce, mprzybylski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated 'sinsp' CMake target_link_libraies() commands to the scoped PRIVATE / PUBLIC / INTERFACE signature. This is to minimize the potential for symbol conflicts in applications that use the library.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Migrates
libsinsptarget_link_library()commands to the scopedPRIVATE/PUBLIC/INTERFACEsignature to reduce the likelihood of symbol conflicts in projects that use the library.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: