-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(userspace/libscap): initialize bpf_engine.m_attached_progs.efd to -1 #1449
Conversation
Welcome @NitroCao! It looks like this is your first PR to falcosecurity/libs 🎉 |
Signed-off-by: Nitro Cao <jaycecao520@gmail.com>
5cedada
to
c454067
Compare
Thanks for the quick PR! but it will most probably be 0.13.4 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 0b327fad0909e33fe0a619961e1d43186fe0e912
|
/cc @Andreagit97 /hold |
/milestone 0.13.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce, NitroCao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libscap-engine-bpf
Does this PR require a change in the driver versions?
What this PR does / why we need it:
alloc_handle()
doesn't initializeengine->m_attached_progs[j].efd
to-1
, which leads todetach_bpf_prog()
closing those file descriptors which are equal to0
unexpectedly.Which issue(s) this PR fixes:
Fixes #1448
Special notes for your reviewer:
Does this PR introduce a user-facing change?: