cleanup(driver, userspace): remove the udig engine #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
Andreagit97
force-pushed
the
cleanup_udig
branch
from
9e6d91c
to
a85b16e
Compare
|
Please double check driver/API_VERSION file. See versioning. /hold |
Andreagit97
commented
Nov 15, 2023
| char *str_storage; /* String storage. Size is one page. */ | ||
| }; | ||
|
|
||
| #define STR_STORAGE_SIZE PAGE_SIZE |
There was a problem hiding this comment.
just moved into another file
This is a false positive |
FedeDP
approved these changes
Nov 15, 2023
|
LGTM label has been added. Git tree hash: f5153ee69f07eeed9c53b0d39fc751f971d50a98
|
LucaGuerra
reviewed
Nov 15, 2023
jasondellaluce
approved these changes
Nov 15, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area driver-kmod
/area libscap-engine-udig
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
This PR removes the udig engine and addressed this issue #1368
Which issue(s) this PR fixes:
Fixes #1368
Special notes for your reviewer:
Does this PR introduce a user-facing change?: