fix(userspace/libscap): prevent libbf stats from being collected with no bpf stats #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no bpf stats Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
poiana
added
release-note-none
kind/bug
|
/milestone 0.14.0 |
|
LGTM label has been added. Git tree hash: fced40b2aa09dbd9bbb6804c7e086616af4b78d7
|
jasondellaluce
dismissed stale reviews from Andreagit97 and FedeDP
via
1a0d407
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
jasondellaluce
force-pushed
the
fix/libbpf-stats-fence
branch
from
1a0d407
to
0df2735
Compare
|
LGTM label has been added. Git tree hash: 9cd5eb28085c71f58e98e3328b479d2ce8b9fcfe
|
incertum
approved these changes
Nov 15, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, incertum, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area libscap-engine-bpf
/area libscap-engine-modern-bpf
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This check used to be in Falco, which however is not the right place as each engine should be responsible of doing safety checks before attempting executing problematic requests.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: