refactor(userspace/libsinsp): remove old meta events implementation #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/milestone 0.14.0 |
|
LGTM label has been added. Git tree hash: ee2910fd968de34dc5de2139fe7af3cae65e7a46
|
|
Thank you very much for the cleanup @jasondellaluce !! |
jasondellaluce
dismissed stale reviews from Andreagit97 and FedeDP
via
cfcd86e
jasondellaluce
force-pushed
the
refactor/deprecate-meta-evt
branch
from
cfcd86e
to
afbc0b0
Compare
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
jasondellaluce
force-pushed
the
refactor/deprecate-meta-evt
branch
from
afbc0b0
to
3ad3e9a
Compare
|
LGTM label has been added. Git tree hash: 42d8ce1e1a806fd4b80d2ada3c66a1c7e518b93c
|
leogr
approved these changes
Nov 24, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR aims to ultimately have only one way in the inspector for injecting asynchronous meta-events. The only piece remaining using the old approach was the generator of internal PROCINFO events. This has now been ported to the async event queue approach.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: