fix(userspace/libsinsp): elems in mpsc queue with same priority follow push order #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llow push order Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
poiana
added
release-note-none
kind/feature
|
/milestone 0.14.0 |
|
LGTM label has been added. Git tree hash: 199f4e170620ef55e14ba42037c4fec5cff05ae9
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
The multi-producer-single-consumer queue follows the given priority order and is used for ordering by timestamp async events in the async queue (with
-1being the dummy timestamp with max priority, representing "pop as soon as possible" events).Elements with the same timestamp do not follow a specific order. However, this is a bug and a breaking changes compared to the previous behavior, in which all elements had
-1timestamp and followed the order in which they were pushed in the queue. This PR fixes and tests this behavior by making sure that elements with the same priority in the queue follow their time of arrival, thus making the new async queue a complete superset of the previously-existing feature with no regression.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: