Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(libsinsp): add scanf formats and fixed size variables in stats.cpp #1506

Merged
merged 2 commits into from Nov 23, 2023

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area libsinsp

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

Tiny refactor of the stats implementation:

  • Use fixed size ints (uint64_t) when reading status files
  • Use the corresponding format specifier for fixed size ints (guarding against compilation warnings)
  • Remove an assert on a condition that may actually happen (it does when you run UTs, especially as non-root)

cc @incertum @jasondellaluce

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@LucaGuerra LucaGuerra changed the title cleanup(libsinsp): add scanf formats and fixed size variables cleanup(libsinsp): add scanf formats and fixed size variables in stats.cpp Nov 23, 2023
@poiana
Copy link
Contributor

poiana commented Nov 23, 2023

LGTM label has been added.

Git tree hash: d23df0ec67c70e144afb4280c0af211945f1fd3a

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, jasondellaluce, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,LucaGuerra,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Andreagit97 Andreagit97 added this to the 0.14.0 milestone Nov 23, 2023
@poiana poiana merged commit 7cb284c into falcosecurity:master Nov 23, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants