cleanup(driver): params inconsistencies #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
release-note-none
kind/bug
|
Please double check driver/API_VERSION file. See versioning. /hold |
ecbadeaux
force-pushed
the
incorrect-flags-issue515
branch
from
b74f452
to
afcb44f
Compare
Signed-off-by: Everett Badeaux <everettc1810@gmail.com>
ecbadeaux
force-pushed
the
incorrect-flags-issue515
branch
from
afcb44f
to
55ad546
Compare
LucaGuerra
approved these changes
Nov 28, 2023
|
LGTM label has been added. Git tree hash: 05d5a1ed0c59d7fcefe4050e9653f304a55143f5
|
incertum
approved these changes
Nov 29, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecbadeaux, incertum, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Andreagit97
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area driver-bpf
Does this PR require a change in the driver versions?
I am not sure about this.
What this PR does / why we need it:
I am trying to address the issue where flock, unshare, and setns is handling the flag params as an unsigned integer when it should be handling it as in int.
Which issue(s) this PR fixes:
part of #515
(partial fix other issues still remain in 515)
Special notes for your reviewer:
Does this PR introduce a user-facing change?: