build: remove some warning suppressions #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Aponte <federico.aponte@sysdig.com>
federico-sysdig
commented
Nov 28, 2023
| @@ -179,7 +179,7 @@ void chisel_view_info::set_sorting_col() | |||
| throw sinsp_exception("view format error: more than one sorting column"); | |||
| } | |||
|
|
|||
| if((int64_t)m_sortingcol < 0) | |||
| if(m_sortingcol < 0) | |||
There was a problem hiding this comment.
Here, the type of m_sortingcol was unsigned and the warning was lamenting that the value could never be negative. The type has been converted to signed.
jasondellaluce
approved these changes
Nov 29, 2023
|
LGTM label has been added. Git tree hash: 497162b13a6d3f0f1ce7f2b976781d8bfe13168e
|
|
/milestone 0.14.0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, federico-sysdig, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
no
What this PR does / why we need it:
The build of this library, when performed with warnings-as-errors enabled, suppresses a number of warnings to be able to get to the end of the build successfully. Some of these suppressions are best avoided and the root cause addressed in order not to have the warnings in the first place. The rationale is that, though more restrictive, compiler warnings are a way to keep code more closely checked and, ultimately, at a higher quality.
FTR, the warnings that the PR re-enables are the following.
missing-field-initializerstype-limitsWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: