cleanup(libsinsp): remove sinsp_evt::get_param_as_json, fix warning #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
|
/milestone 0.14.0 |
|
LGTM label has been added. Git tree hash: aafab8112e175c7464267318598e0fd797ee12ef
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Follow me in my magical journey this morning:
Recently I changed the way we access parameters in
get_param_as_strbut inget_param_as_jsonthis was changed only partially, meaning that I could have introduced a bug that should be fixed before release.I then noticed that
get_param_as_jsondid not have any test.I also noticed that
get_param_as_jsondid not have any callers.Then a look at the git history shows that it was introduced in 2014 7544aeb and became unreachable code about two months later d1a1081 .
I am not aware of any other libs client calling this function. Good bye 馃憢
I also snuck in a fix for a truncation warning for snprintf.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: