Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(driver): add support for newfstatat syscall #1628

Merged
merged 6 commits into from Jan 23, 2024
Merged

feat(driver): add support for newfstatat syscall #1628

merged 6 commits into from Jan 23, 2024

Conversation

mrgian
Copy link
Contributor

@mrgian mrgian commented Jan 18, 2024 •
edited by jasondellaluce

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

falcosecurity/falco#1998

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat(driver): add support for newfstatat syscall

@mrgian
feat(driver): add support for newfstatat syscall
2450f8e 
Signed-off-by: Gianmatteo Palmieri <mail@gian.im>
@mrgian
fix(driver): don't send buffer pointer to userspace
1cd6f07 
Signed-off-by: Gianmatteo Palmieri <mail@gian.im>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited

Please double check driver/API_VERSION file. See versioning.

/hold

@mrgian
chore(driver): bump schema version
75c2615 
Signed-off-by: Gianmatteo Palmieri <mail@gian.im>
@mrgian
fix: indentation issues
e3923d9 
Signed-off-by: Gianmatteo Palmieri <mail@gian.im>
@mrgian
Copy link
Contributor Author

mrgian commented Jan 19, 2024 •
edited

@falcosecurity/libs-maintainers @FedeDP @Andreagit97
Currently the name for this new event is newfstatat, the same name as the syscall, however newfstatat and fstatat64 are internal names for fstatat (if I'm not wrong)
So we can think about renaming the event to just fstatat
WDYT?

@FedeDP
Copy link
Contributor

FedeDP commented Jan 19, 2024

Given that it has its own __NR_ number, i think it is ok to leave it as is.
Btw thanks for opening this PR!
Will give it a look asap!
/milestone next-driver

@poiana poiana added this to the next-driver milestone Jan 19, 2024
FedeDP
FedeDP previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jan 23, 2024
@poiana
Copy link
Contributor

poiana commented Jan 23, 2024

LGTM label has been added.

Git tree hash: 74230325fe2b8a85f701a05234c69a21123c1002

jasondellaluce
jasondellaluce previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Andreagit97
Andreagit97 reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

driver/bpf/fillers.h Outdated Show resolved Hide resolved
driver/bpf/fillers.h Outdated Show resolved Hide resolved
driver/ppm_flag_helpers.h Show resolved Hide resolved
@mrgian
chore(driver): remove unnecessary comments
545e233 
Signed-off-by: Gianmatteo Palmieri <mail@gian.im>
@mrgian mrgian dismissed stale reviews from jasondellaluce and FedeDP via 545e233 January 23, 2024 11:50
@poiana poiana removed the lgtm label Jan 23, 2024
@mrgian
chore(driver): add comment about flag definition
2fd4a7e 
Signed-off-by: Gianmatteo Palmieri <mail@gian.im>
FedeDP
FedeDP approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jan 23, 2024
@poiana
Copy link
Contributor

poiana commented Jan 23, 2024

LGTM label has been added.

Git tree hash: a95d6ec9ed509704abe7d9134bc251fbe120113d

Andreagit97
Andreagit97 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!
/approve

@poiana
Copy link
Contributor

poiana commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce, mrgian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Andreagit97
Copy link
Member

/unhold

@poiana poiana merged commit 645315e into falcosecurity:master Jan 23, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@jasondellaluce jasondellaluce Awaiting requested review from jasondellaluce

Assignees

@FedeDP FedeDP

@jasondellaluce jasondellaluce

@Andreagit97 Andreagit97

Labels
approved area/driver-bpf area/driver-kmod area/driver-modern-bpf area/libpman dco-signoff: yes kind/feature New feature or request lgtm release-note size/XL
Projects
None yet
Milestone
7.1.0+driver
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mrgian @FedeDP @poiana @Andreagit97 @jasondellaluce