update(cmake): Use the static CRT on Windows by default #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incertum
previously approved these changes
Feb 15, 2024
|
LGTM label has been added. Git tree hash: b8190ddd88d4bea75f8d5cbb581f0db86fb6f789
|
|
/milestone 0.15.0 |
LucaGuerra
previously approved these changes
Feb 15, 2024
Set CMAKE_MSVC_RUNTIME_LIBRARY to "MultiThreaded" unless it was set externally or if we're building shared libs. This - uses CMake's documented variable to control CRT linking. - ensures that we use the static CRT by default. - allows the CRT setting to be overridden. Add a Windows shared CRT CI job. Signed-off-by: Gerald Combs <gerald@wireshark.org>
geraldcombs
dismissed stale reviews from LucaGuerra and incertum
via
ac13242
geraldcombs
force-pushed
the
cmake-msvc-runtime-default-static
branch
from
03123c6
to
ac13242
Compare
The build-libs-others-amd64 wasn't testing the proper combinations. |
LucaGuerra
approved these changes
Feb 16, 2024
|
LGTM label has been added. Git tree hash: 525dac5f3d20cdc0e7ec74b91ff0dda9a1edb2a0
|
leogr
approved these changes
Feb 16, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, geraldcombs, incertum, leogr, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set CMAKE_MSVC_RUNTIME_LIBRARY to "MultiThreaded" unless it was set externally or if we're building shared libs. This
Add a Windows shared CRT CI job.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
/area CI
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: