-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle capset_x missing thread_info #818
Conversation
Signed-off-by: Adnan Ali <adduali1310@hotmail.com>
Welcome @adduali1310! It looks like this is your first PR to falcosecurity/libs 🎉 |
/lgtm |
LGTM label has been added. Git tree hash: 81bb41e9299124c899b100cae8b8e4325f314237
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adduali1310 thank you very much for that, nice catch!
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Great finding!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adduali1310, Andreagit97, FedeDP, loresuso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think this is suitable for |
@FedeDP: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/release-note-none |
Signed-off-by: Adnan Ali adduali1310@hotmail.com
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libsinsp
What this PR does / why we need it:
This PR adds a safety check to validate if thread information is available before trying to dereference it when parsing the capset_exit event.
Should be a straightforward change and follows other such checks within the code file as mentioned in the issue.
Which issue(s) this PR fixes:
Fixes #817
Does this PR introduce a user-facing change?:
NONE