Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle capset_x missing thread_info #818

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

adduali1310
Copy link
Contributor

@adduali1310 adduali1310 commented Dec 28, 2022

Signed-off-by: Adnan Ali adduali1310@hotmail.com

What type of PR is this?
/kind bug

Any specific area of the project related to this PR?
/area libsinsp

What this PR does / why we need it:
This PR adds a safety check to validate if thread information is available before trying to dereference it when parsing the capset_exit event.
Should be a straightforward change and follows other such checks within the code file as mentioned in the issue.

Which issue(s) this PR fixes:
Fixes #817

Does this PR introduce a user-facing change?:
NONE

Signed-off-by: Adnan Ali <adduali1310@hotmail.com>
@poiana
Copy link
Contributor

poiana commented Dec 28, 2022

Welcome @adduali1310! It looks like this is your first PR to falcosecurity/libs 🎉

@loresuso
Copy link
Member

loresuso commented Jan 4, 2023

/lgtm

@poiana
Copy link
Contributor

poiana commented Jan 4, 2023

LGTM label has been added.

Git tree hash: 81bb41e9299124c899b100cae8b8e4325f314237

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adduali1310 thank you very much for that, nice catch!
/approve

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Great finding!
/approve

@poiana
Copy link
Contributor

poiana commented Jan 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adduali1310, Andreagit97, FedeDP, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Jan 4, 2023

I think this is suitable for
/milestone 0.10.0

@poiana
Copy link
Contributor

poiana commented Jan 4, 2023

@FedeDP: The provided milestone is not valid for this repository. Milestones in this repository: [0.11.0, next-driver]

Use /milestone clear to clear the milestone.

In response to this:

I think this is suitable for
/milestone 0.10.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adduali1310
Copy link
Contributor Author

/release-note-none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infrequent Segfaults for CAPSET_X
5 participants