Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prow build #5

Merged
merged 3 commits into from Sep 23, 2021
Merged

Fix prow build #5

merged 3 commits into from Sep 23, 2021

Conversation

mstemm
Copy link
Contributor

@mstemm mstemm commented Sep 21, 2021 •
edited

  1. Make build.sh executable so it can be directly invoked from the prow job.
  2. Add a pull request template

The below will be a part of the template once merged, this is just to keep poiana happy in the meantime.

NONE

@mstemm
Make build.sh executable
c0e3483 
It's directly called in the command for the job, so make it executable.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
@mstemm
Add pull request template
718e8a0 
Derived from falcosecurity/libs, with small change to kind/area/action
example.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
@poiana
Copy link

poiana commented Sep 21, 2021

@mstemm: There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

leogr
leogr reviewed Sep 22, 2021
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mstemm

We have to wait until falcosecurity/test-infra#519 should get merged, then we can retest this PR (hoping it works this time 😸 )

Thank you

@leogr
Copy link
Member

leogr commented Sep 23, 2021

/retest

@leogr
fix(build.sh): add shebang
d8d38fa 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
leogr
leogr approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PS I have added the shebang that was missing

@poiana poiana added the lgtm label Sep 23, 2021
@poiana
Copy link

poiana commented Sep 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Sep 23, 2021

LGTM label has been added.

Git tree hash: 0cd0553f8cfcf25f7bf7444238e825bf89d0b32d

@poiana poiana merged commit c7841e2 into main Sep 23, 2021
@poiana poiana deleted the fix-prow-build branch September 23, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@fntlnz fntlnz Awaiting requested review from fntlnz

@krisnova krisnova Awaiting requested review from krisnova

Assignees

@leogr leogr

Labels
approved dco-signoff: yes lgtm needs-kind release-note-none size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mstemm @poiana @leogr