-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(cloudtrail): Update ct.resources handling #506
update(cloudtrail): Update ct.resources handling #506
Conversation
Rules files suggestionsrulesComparing No changes detected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @geraldcombs
Just a minor thing, otherwise SGTM!
Also, can you bump the plugin version to 0.12.3
, please? 🙏
Thanks
Generalize our array length check. Use strings.TrimSuffix in order to avoid a potential string under-read. Signed-off-by: Gerald Combs <gerald@wireshark.org>
82feae2
to
62c7b8d
Compare
Rules files suggestionsrulesComparing No changes detected |
LGTM label has been added. Git tree hash: b8beb448f25c0eccc9c57f517b045c0a86b6fe49
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geraldcombs, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Generalize our array length check. Use strings.TrimSuffix in order to avoid a potential string under-read.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: