Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(cloudtrail): Update ct.resources handling #506

Merged
merged 1 commit into from
Jun 17, 2024
Merged

update(cloudtrail): Update ct.resources handling #506

merged 1 commit into from
Jun 17, 2024

Conversation

geraldcombs
Copy link
Contributor

Generalize our array length check. Use strings.TrimSuffix in order to avoid a potential string under-read.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana poiana added the size/XS label Jun 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024

Rules files suggestions

rules

Comparing 82feae254f40ff64e9992abdf4ea80e4674f979d with latest tag plugins/cloudtrail/v0.12.2

No changes detected

leogr
leogr reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @geraldcombs
Just a minor thing, otherwise SGTM!

Also, can you bump the plugin version to 0.12.3, please? 🙏

Thanks

plugins/cloudtrail/pkg/cloudtrail/extract.go Outdated Show resolved Hide resolved
@leogr leogr mentioned this pull request Jun 17, 2024
Merged
@geraldcombs
update(cloudtrail): Update ct.resources handling
62c7b8d 
Generalize our array length check. Use strings.TrimSuffix in order to
avoid a potential string under-read.

Signed-off-by: Gerald Combs <gerald@wireshark.org>
@github-actions GitHub Actions
Copy link

Rules files suggestions

rules

Comparing 62c7b8dbfc604b7a07f8317125f85bb9c9ba784f with latest tag plugins/cloudtrail/v0.12.2

No changes detected

@poiana poiana added the lgtm label Jun 17, 2024
@poiana
Copy link
Contributor

poiana commented Jun 17, 2024

LGTM label has been added.

Git tree hash: b8beb448f25c0eccc9c57f517b045c0a86b6fe49

@poiana
Copy link
Contributor

poiana commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geraldcombs, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit fbd9f48 into falcosecurity:main Jun 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@jasondellaluce jasondellaluce Awaiting requested review from jasondellaluce

@mstemm mstemm Awaiting requested review from mstemm

Assignees

@leogr leogr

Labels
approved area/plugins dco-signoff: yes kind/cleanup lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geraldcombs @poiana @leogr