feat(plugins/okta): introduce optional UseAsync field in okta plugin #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sanja Kosier <sanja.kosier@sysdig.com>
Rules files suggestionsrulesComparing Minor changes:
|
leogr
reviewed
Jun 13, 2024
SKosier
force-pushed
the
skosier/plugins/okta/introduce-use-async
branch
from
a581691
to
8652183
Compare
Rules files suggestionsrulesComparing Minor changes:
|
leogr
approved these changes
Jun 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, SKosier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 9384b7299857ad2fd4a40aedca98b36dd55dfb08
|
|
@SKosier could create another PR to update the changelog and the plugin version. Moreover, the parameter has to be used in the Init() func, see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: