-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins/okta): introduce optional UseAsync field in okta plugin #507
feat(plugins/okta): introduce optional UseAsync field in okta plugin #507
Conversation
Signed-off-by: Sanja Kosier <sanja.kosier@sysdig.com>
Rules files suggestionsrulesComparing Minor changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please switch the version number to 0.11.0
Otherwise, SGMT.
a581691
to
8652183
Compare
Rules files suggestionsrulesComparing Minor changes:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, SKosier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 9384b7299857ad2fd4a40aedca98b36dd55dfb08
|
@SKosier could create another PR to update the changelog and the plugin version. Moreover, the parameter has to be used in the Init() func, see
|
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: