Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation jobs should run on the jobs node group #1148

Closed
maxgio92 opened this issue May 15, 2023 · 5 comments
Closed

Validation jobs should run on the jobs node group #1148

maxgio92 opened this issue May 15, 2023 · 5 comments

Comments

@maxgio92
Copy link
Member

maxgio92 commented May 15, 2023

Feature request

Validation jobs should run on the jobs node group.

They should be configured with appropriate selection and tolerations, at PodSpec-level. E.g.:

      tolerations:
      - key: "Archtype"
        operator: "Equal"
        value: "arm"
        effect: "NoSchedule"
      - key: "Availability"
        operator: "Equal"
        value: "SingleAZ"
        effect: "NoSchedule"
      nodeSelector:
        Archtype: "arm"
        Application: "jobs"

Additional context

Otherwise, those jobs would run on the Prow-dedicated node group.

For examples, take a look at https://github.com/falcosecurity/test-infra/blob/master/config/jobs/build-drivers/.

@poiana
Copy link
Contributor

poiana commented Aug 13, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented Sep 11, 2023

/remove-lifecycle stale

Still relevant @maxgio92 ?

@poiana
Copy link
Contributor

poiana commented Dec 10, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented Dec 10, 2023

/close

We now have a single drivers config validate job that runs on the jobs node group: https://github.com/falcosecurity/test-infra/blob/master/config/jobs/build-drivers/validate-dbg.yaml

@poiana poiana closed this as completed Dec 10, 2023
@poiana
Copy link
Contributor

poiana commented Dec 10, 2023

@FedeDP: Closing this issue.

In response to this:

/close

We now have a single drivers config validate job that runs on the jobs node group: https://github.com/falcosecurity/test-infra/blob/master/config/jobs/build-drivers/validate-dbg.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants